Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the deletion request ping in Glean #526

Merged
merged 25 commits into from
Dec 3, 2019
Merged

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 25, 2019

@badboy badboy changed the title Deletion request Implement the deletion request ping in Glean Nov 25, 2019
@badboy badboy marked this pull request as ready for review November 25, 2019 17:06
@badboy badboy added the needs:data-review PR is awaiting a data review label Nov 25, 2019
@badboy badboy force-pushed the deletion-request branch 2 times, most recently from 0accc2e to 196054e Compare November 25, 2019 17:20
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about enabling cleartext and a couple nits about setting initial state of preference toggles in sample applications.

Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. This looks good as a start, I have no major complain, just a bunch of nits here and there on the Android part. I'm leaving the iOS part to @travis79 .

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good, with @Dexterp37's concerns addressed

@badboy
Copy link
Member Author

badboy commented Nov 26, 2019

Blocked by #528

@badboy badboy added the blocked Blocked pull requests and issues label Nov 26, 2019
@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #526 into master will decrease coverage by 0.32%.
The diff coverage is 46.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #526      +/-   ##
===========================================
- Coverage     75.92%   75.6%   -0.33%     
- Complexity      333     334       +1     
===========================================
  Files            96      98       +2     
  Lines          5649    5730      +81     
  Branches        703     714      +11     
===========================================
+ Hits           4289    4332      +43     
- Misses          842     879      +37     
- Partials        518     519       +1
Impacted Files Coverage Δ Complexity Δ
glean-core/ios/Glean/Net/HttpPingUploader.swift 82.65% <100%> (+0.17%) 0 <0> (ø) ⬇️
glean-core/ios/Glean/Glean.swift 92.63% <100%> (+0.28%) 0 <0> (ø) ⬇️
...oid/src/main/java/mozilla/telemetry/glean/Glean.kt 88.82% <100%> (+0.05%) 1 <0> (ø) ⬇️
...emetry/glean/scheduler/DeletionPingUploadWorker.kt 25% <25%> (ø) 1 <1> (?)
glean-core/src/lib.rs 62.43% <50%> (-0.67%) 0 <0> (ø)
glean-core/src/internal_pings.rs 58.33% <58.33%> (ø) 0 <0> (?)
glean-core/src/ping/mod.rs 68.23% <71.42%> (+0.57%) 0 <0> (ø) ⬇️
glean-core/src/metrics/datetime.rs 44.23% <0%> (+3.84%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a172240...5cdaedf. Read the comment docs.

@badboy badboy removed the blocked Blocked pull requests and issues label Nov 28, 2019
This for now also removed the auto-generated documentation for the ping.
That's a bug in the glean_parser and will be fixed later.
@badboy badboy requested a review from Dexterp37 November 29, 2019 09:24
glean-core/ios/Glean/Glean.swift Show resolved Hide resolved
@badboy badboy removed the needs:data-review PR is awaiting a data review label Dec 3, 2019
@badboy badboy merged commit 9a8413d into master Dec 3, 2019
@badboy badboy deleted the deletion-request branch December 3, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants