-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the deletion request ping in Glean #526
Conversation
4a986fd
to
6804da7
Compare
0accc2e
to
196054e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about enabling cleartext and a couple nits about setting initial state of preference toggles in sample applications.
samples/android/app/src/main/java/org/mozilla/samples/glean/MainActivity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. This looks good as a start, I have no major complain, just a bunch of nits here and there on the Android part. I'm leaving the iOS part to @travis79 .
...roid/app/src/androidTest/java/org/mozilla/samples/gleancore/pings/DeletionRequestPingTest.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/DeletionPingUploadWorker.kt
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/DeletionPingUploadWorker.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/DeletionPingUploadWorker.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good, with @Dexterp37's concerns addressed
Blocked by #528 |
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
===========================================
- Coverage 75.92% 75.6% -0.33%
- Complexity 333 334 +1
===========================================
Files 96 98 +2
Lines 5649 5730 +81
Branches 703 714 +11
===========================================
+ Hits 4289 4332 +43
- Misses 842 879 +37
- Partials 518 519 +1
Continue to review full report at Codecov.
|
This for now also removed the auto-generated documentation for the ping. That's a bug in the glean_parser and will be fixed later.
4569cdc
to
f359ef5
Compare
3913ed2
to
5cdaedf
Compare
https://bugzilla.mozilla.org/show_bug.cgi?id=1587095