Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NDEBUG in the build environment #422

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Set NDEBUG in the build environment #422

merged 3 commits into from
Oct 29, 2019

Conversation

badboy
Copy link
Member

@badboy badboy commented Oct 29, 2019

No description provided.

Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with test passing :) Let's also check that this doesn't crash the emulator (if you didn't try yet)

@badboy
Copy link
Member Author

badboy commented Oct 29, 2019

[~glean]  (git:lmdb-ndebug%)
❯ TARGET_CFLAGS=-DNDEBUG ./gradlew build -x test :glean-sample-app:connectedAndroidTest -PdisablePreDexg
[...]
BUILD SUCCESSFUL in 1m 0s
174 actionable tasks: 10 executed, 164 up-to-date

[~glean]  (git:lmdb-ndebug%)
❯ objdump -T glean-core/android/build/rustJniLibs/android/x86/libglean_ffi.so  | rg stderr

[~glean]  (git:lmdb-ndebug%)
❯ adb shell getprop ro.build.version.release
5.0.2

[~glean]  (git:lmdb-ndebug%)
❯ adb shell getprop ro.build.version.sdk
21

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #422 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #422      +/-   ##
============================================
+ Coverage     76.38%   76.39%   +<.01%     
  Complexity      308      308              
============================================
  Files            95       95              
  Lines          5362     5363       +1     
  Branches        627      627              
============================================
+ Hits           4096     4097       +1     
  Misses          802      802              
  Partials        464      464
Impacted Files Coverage Δ Complexity Δ
...n/java/mozilla/telemetry/glean/rust/LibGleanFFI.kt 66.66% <0%> (+1.96%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4cde2...2f5f303. Read the comment docs.

@badboy badboy merged commit fefa14d into master Oct 29, 2019
@badboy badboy deleted the lmdb-ndebug branch October 29, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants