1589743: Don't log pings twice

[mdboom]

This now matches the behavior of glean-ac (logging from the uploader)

[codecov-io]

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##             master     #407      +/-   ##
============================================
+ Coverage     76.27%   76.29%   +0.01%     
  Complexity      308      308              
============================================
  Files            95       95              
  Lines          5369     5365       -4     
  Branches        631      629       -2     
============================================
- Hits           4095     4093       -2     
+ Misses          806      805       -1     
+ Partials        468      467       -1

Impacted Files	Coverage Δ	Complexity Δ
...n/java/mozilla/telemetry/glean/rust/LibGleanFFI.kt	66.66% <ø> (ø)	0 <0> (ø)	⬇️
glean-core/src/event_database/mod.rs	53.59% <0%> (ø)	0 <0> (ø)	⬇️
...oid/src/main/java/mozilla/telemetry/glean/Glean.kt	85.48% <100%> (-0.08%)	1 <0> (ø)
glean-core/ios/Glean/Glean.swift	92.35% <100%> (-0.05%)	0 <0> (ø)
glean-core/src/metrics/ping.rs	25% <100%> (ø)	0 <0> (ø)	⬇️
glean-core/src/lib.rs	62.03% <60%> (+0.12%)	0 <0> (ø)	⬇️
...c/main/java/mozilla/telemetry/glean/Dispatchers.kt	78.26% <0%> (+0.98%)	1% <0%> (ø)	⬇️
...in/java/mozilla/telemetry/glean/utils/DateUtils.kt	78.57% <0%> (+1.29%)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345288b...d08c7c1. Read the comment docs.

[badboy]

I initially had concerns regarding where to log.
Keeping that only in Rust would mean we don't need to do it again for iOS as well.
But I guess keeping it in the uploader makes more sense, otherwise we might miss some that are triggered from Rust internally where we don't have the state to log these, right?

[mdboom]

But I guess keeping it in the uploader makes more sense, otherwise we might miss some that are triggered from Rust internally where we don't have the state to log these, right?

Yes, I think so.

All of this will probably need to be revisited with the planned architecture refactor to have the Rust core more "in charge" of uploading.