Keep track of pings in all modes #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to keep track of pings, so they get re-registered after a reset. This state is kept across Glean resets, which should only ever happen in test mode. Or by the instrumentation tests (`connectedAndroidTest`), which relaunches the application activity, but not the whole process, meaning globals, such as the ping types, still exist from the old run. I'm not super happy with keeping this state around, but given that the queue is actually a set and it's unlikely to have hundreds and hundreds of custom pings it should not have much of an impact.
|
cc @brizental |
travis79
approved these changes
Oct 15, 2019
Dexterp37
reviewed
Oct 15, 2019
| // This state is kept across Glean resets, which should only ever happen in test mode. | ||
| // Or by the instrumentation tests (`connectedAndroidTest`), which relaunches the application activity, | ||
| // but not the whole process, meaning globals, such as the ping types, still exist from the old run. | ||
| // It's a set and keeping them around forver should not have much of an impact. |
There was a problem hiding this comment.
Would it make sense to try to reset in the GleanTestRunner?
There was a problem hiding this comment.
Yeah, I'm too am curious if we can fix this in a testing-only way...
There was a problem hiding this comment.
I considered it, but decided against it for reasons:
- Low overhead even in production
- It's yet another configuration/state the GleanTestRunner runs in compared to unit tests and production mode.
- I'd like the tests to run as close to production as possible, otherwise we might miss other problems
- It was easier to remove code than to add :P
mdboom
reviewed
Oct 15, 2019
glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt
Outdated
Show resolved
Hide resolved
| // This state is kept across Glean resets, which should only ever happen in test mode. | ||
| // Or by the instrumentation tests (`connectedAndroidTest`), which relaunches the application activity, | ||
| // but not the whole process, meaning globals, such as the ping types, still exist from the old run. | ||
| // It's a set and keeping them around forver should not have much of an impact. |
There was a problem hiding this comment.
Yeah, I'm too am curious if we can fix this in a testing-only way...
Co-Authored-By: Michael Droettboom <[email protected]>
Dexterp37
approved these changes
Oct 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
============================================
+ Coverage 75.76% 75.76% +<.01%
+ Complexity 308 307 -1
============================================
Files 95 95
Lines 5323 5319 -4
Branches 631 629 -2
============================================
- Hits 4033 4030 -3
Misses 825 825
+ Partials 465 464 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep track of pings, so they get re-registered after a reset.
This state is kept across Glean resets, which should only ever happen in test mode.
Or by the instrumentation tests (
connectedAndroidTest), which relaunches the application activity,but not the whole process, meaning globals, such as the ping types, still exist from the old run.
I'm not super happy with keeping this state around, but given that the
queue is actually a set and it's unlikely to have hundreds and hundreds
of custom pings it should not have much of an impact.