Bug 1656589 - Track the database size on initialization

[badboy]

No description provided.

[Dexterp37]

This LGTM, but how does it make the tests on Android fail!?

[badboy]

This LGTM, but how does it make the tests on Android fail!?

I think I know why: we now have a metric available for each metrics ping.
Previously our tests relied on it being empty most of the time and thus it not getting sent.
Now that it has a never-cleared metric it will always get sent.

That brings up the questions:

• Ping or Application lifetime? Ping means we only get it once, I guess that is still enough for analysis, given it doesn't change for the application lifetime anyway?
• Is the metrics ping even the right place for it?

[badboy]

Choosing a lifetime=user would indeed make tests pass.

It doesn't, I compiled the wrong code.

[Dexterp37]

This LGTM, but how does it make the tests on Android fail!?

I think I know why: we now have a metric available for each metrics ping.
Previously our tests relied on it being empty most of the time and thus it not getting sent.
Now that it has a never-cleared metric it will always get sent.

That brings up the questions:

* Ping or Application lifetime? Ping means we only get it once, I guess that is still enough for analysis, given it doesn't change for the application lifetime anyway?

I think Ping lifetime is fine. If we restart multiple times before sending a metric ping, we're sending a timing distribution anyway, so we'll record multiple values.

* Is the metrics ping even the right place for it?

Yes, I believe it is, still. We make no guarantee or assumption about this ping not being sent.

[badboy]

I had to resort to sort of a small hack to get tests passing by ignoring the metrics ping (by essentially delaying it). That touches far too many tests to my liking, but it's the unfortunate truth how it all works.

I'd like some review on that. It also means we now always have a metrics ping because we are recording metrics (but in actual applications we might not be the only ones anyway, so probably not a real problem?)

[badboy]

Ah! I also think the same has to be done for iOS, which I haven't done yet. I also never ran the tests for iOS yet.

[away]

[travis79]

LGTM