Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1644364 - Move logic to limit max retries on recoverable failures to glean-core #1120

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Bug 1644364 - Move logic to limit max retries on recoverable failures to glean-core #1120

merged 8 commits into from
Aug 4, 2020

Commits on Aug 4, 2020

  1. Limit retries for failed ping uploads from glean-core

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    9e8880c View commit details
    Browse the repository at this point in the history

  2. Remove recoverable failure limitation logic from bindings

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    93052ac View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary changes to metrics.md

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5beaa8b View commit details
    Browse the repository at this point in the history

  4. Fix python lints

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    bacd18e View commit details
    Browse the repository at this point in the history

  5. Update docstrings with new intent of PingUploadTask::Done

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    c88fb8d View commit details
    Browse the repository at this point in the history

  6. Attend to review comments 

    * period -> uploading window;
* get_upload_task_job -> get_upload_task_internal;
* Add comment to all bindings on how we avoind infinite loops;
* Correct position of incoming task comment in Kt;
* Add CHANGELOG.md entry;
    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    0af1433 View commit details
    Browse the repository at this point in the history

  7. Add 'enqueued' to dictionary

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    206d9b4 View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG.md

    @brizental
    brizental committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    86269e3 View commit details
    Browse the repository at this point in the history