Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1601550 - Enforce disk quota on pending pings directory #1110

Merged
merged 12 commits into from
Aug 7, 2020
Merged

Bug 1601550 - Enforce disk quota on pending pings directory #1110

merged 12 commits into from
Aug 7, 2020

Commits on Aug 7, 2020

  1. Fix regression in fills_up_queue_successfully_from_disk test 

    The test was not checking if pings were actually loadedfrom disk
    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    5b02224 View commit details
    Browse the repository at this point in the history

  2. Enforce disk quota on pending pings directory

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    9497832 View commit details
    Browse the repository at this point in the history

  3. Instrument scanning of pending pings dir on init

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    1f53e0f View commit details
    Browse the repository at this point in the history

  4. deleted_pending_pings_after_quota_hit -> deleted_pings_after_quota_hit

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ca99a64 View commit details
    Browse the repository at this point in the history

  5. Build documentation for the new added metrics

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ff1894f View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Jan-Erik Rediger <[email protected]>
    @badboy @brizental
    2 people authored and brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    53e1057 View commit details
    Browse the repository at this point in the history

  7. Attend to review comments

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    541a60a View commit details
    Browse the repository at this point in the history

  8. Fix failing android tests 

    The problem was that the test was trying to get a request sent
by a worker, but that worker received a PingUploadTask::Wait before
getting a PingUploadTask::Upload and the test was trying to check the
request before it had actually arrived.

This is potentially an issue with more tests, but it only manifested
in this test for now. I opened Bug 1657589 for more in depth
investigation on this.
    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    2dd72b4 View commit details
    Browse the repository at this point in the history

  9. Fix android lints

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    2937a94 View commit details
    Browse the repository at this point in the history

  10. Add back removed import from deletion kt tests

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    3971673 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Jan-Erik Rediger <[email protected]>
    @badboy @brizental
    2 people authored and brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    d66bc88 View commit details
    Browse the repository at this point in the history

  12. Fix algorith to actually delete oldest pings first

    @brizental
    brizental committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    0979629 View commit details
    Browse the repository at this point in the history