-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1669964 - Fix code generation for pmin/pmax on x86. r=jseward
pmin and pmax handled NaN incorrectly because the wonky semantics of MINPS and MAXPS require arguments to be reversed to properly handle NaN for these wasm SIMD instructions. We fix this the expedient way: we keep the same masm abstraction and introduce moves to rearrange the arguments. This should be optimized eventually and a bug will be filed for that now. Differential Revision: https://phabricator.services.mozilla.com/D92927
- Loading branch information
Lars T Hansen
committed
Oct 14, 2020
1 parent
dec2b41
commit 49c0d8a
Showing
2 changed files
with
18 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters