This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Backport ECDH key validation from private repo #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently allow devices to submit invalid public keys with their push registration, causing attempts to notify those devices to fail in an ugly way. This adds additional validation so that only known-good keys get stored in the db.
|
Ouch. Have you seen real Firefox clients submit invalid keys? |
Fortunately no; we had some bogus keys in our tests that were causing strange failures. |
|
Whew. 😅 Still a hideous bug, but it's great to hear clients in the wild haven't been doing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the now-deployed-to-production code from https://github.com/mozilla/fxa-auth-server-private/pull/65 into the public repo. It validates incoming push public keys before writing them to the db, and does so in a way that works around a bug node's handling of invalid keys:
nodejs/node#13275
@vladikoff r?