MPP-2083: Retire eu_country_expansion flag, backend#3745
Merged
Conversation
The flag was turned on in production on 2023-08-01. This integrates the expanded premium countries into the existing countries, and treats the flag as on for everyone on the backend.
eu_country_expansion flag, backendeu_country_expansion flag, backend
groovecoder
approved these changes
Aug 8, 2023
Member
groovecoder
left a comment
There was a problem hiding this comment.
Code looks good. I didn't spot-check but the tests are all passing. If you'd like me to spot-check on my machine let me know, or just merge when ready.
Contributor
Author
|
Since this is basically static data, I'm happy with tests passing, no manual testing needed. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag was turned on in production on 2023-08-01. This integrates the expanded premium countries into the existing countries, and treats the flag as on for everyone on the backend. There is additional work needed to retire the flag on the front-end.