-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nimbus): Approval and rejection flow #12090
base: main
Are you sure you want to change the base?
feat(nimbus): Approval and rejection flow #12090
Conversation
Blocked on #11932 |
Okay! This is already looking great 🎉 🎉 🎉 Couple things I notice from local testing:
Look at what the V5 serializer does here on save: We need to do these same things. |
@jaredlockhart rejection message not showing up is related to changelog issue and that's why it's not included. I have added all the sync issues which was happening on the serializer to the forms, it should be called immediately now. I will investigate the changelog issue and made a point to implement this rejection message functionality with it. |
Because
This commit
Fixes #12072
Note: This currently does not show the rejection reason-which I will add in the separate PR
Approval flow
Untitled.mov
Rejection flow
Screen.Recording.2025-01-22.at.3.38.00.PM.mov
Timeout message