Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nimbus): Enrollment and complete days #11711

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

yashikakhurana
Copy link
Contributor

Because

  • We are not showing days (enrollment days and total duration of the experiment) on the new summary page

This commit

  • Add enrollment days
  • Add total duration of the experiment

Fixes #1
Screenshot 2024-11-06 at 12 45 37 PM
1710

@yashikakhurana
Copy link
Contributor Author

Blocked on #11709

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think we should only ever have one of the status boxes highlighted at a time?

image

Also we could change 'live' to 'enrolling' and 'enrollment end' to 'observing' to make the titles shorter and maybe a little clearer?

Also I like adding teh 'X days' to them, we should put that on all of them, but we can do that seprately.

@yashikakhurana
Copy link
Contributor Author

Oh, I think we should only ever have one of the status boxes highlighted at a time?
image

Also we could change 'live' to 'enrolling' and 'enrollment end' to 'observing' to make the titles shorter and maybe a little clearer?

Also I like adding the 'X days' to them, we should put that on all of them, but we can do that seprately.

made the changes to show only one box active at a time and changed the name
Screenshot 2024-11-12 at 10 22 15 AM
Screenshot 2024-11-12 at 10 21 02 AM
Screenshot 2024-11-12 at 10 19 37 AM
Screenshot 2024-11-12 at 10 13 59 AM
Screenshot 2024-11-12 at 10 13 43 AM
Screenshot 2024-11-12 at 10 13 19 AM

To add days in each section- I filled the ticket for that #11747

Copy link
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the change from "Live" to "Enrolling" and "Enrollment End" to "Observing" it's muddled the "# days" indicators. To me it's a bit confusing that "Observing" shows the # of days that were spent enrolling, and this should instead go under "Enrolling", with a separate computed duration for the observation (end_date - enrollment_end_date).

experimenter/experimenter/experiments/models.py Outdated Show resolved Hide resolved
experimenter/experimenter/experiments/constants.py Outdated Show resolved Hide resolved
@yashikakhurana
Copy link
Contributor Author

@mikewilli I changed and moved the days around, do you want to take another look? Also thank you for bringing that up

Copy link
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Circle CI
3 participants