-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty [workspace] to Cargo.toml. #94
Conversation
This works around rust-lang/cargo#6745 and allows cubeb-pulse-rs to appear as a subdirectory of a workspace member in another project (for instance, cubeb-rs).
cc @padenot - any chance of taking a look at this? thanks! |
cc @kinetiknz on this one as well |
Looks like this may have cause clippy to start running on things it wasn't running on before(?) |
Yeah, clippy is now including pulse-rs and pulse-ffi. Quick fix is to exclude those crates from the workspace (which would be equivalent to the behaviour before |
I think there are far too many errors for me to fix them in this PR, in particular as a number of them are due to missing |
On second thought, I think the approach I took with that last commit is not quite right; it might also break anyone running |
@kinetiknz this is ready for a re-review now :) ( @padenot - if you could please trigger a presubmit run so I can fix any lingering errors I missed locally, I'd appreciate it) |
One of the nightly errors is due to rust-lang/rust-clippy#13531. I can fix the others. |
And this should be ready for a re-run now, too |
Largely autogenerated, with a bit of manual cleanup for extra whitespace.
mozilla#95 tracks fixing these in the future.
reformatted |
Thank you! |
Specifically, pull in mozilla/cubeb-coreaudio-rs#236 and mozilla/cubeb-pulse-rs#94
Thanks! |
Specifically, pull in mozilla/cubeb-coreaudio-rs#236 and mozilla/cubeb-pulse-rs#94
This works around rust-lang/cargo#6745 and allows cubeb-pulse-rs to appear as a subdirectory of a workspace member in another project (for instance, cubeb-rs).