Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty [workspace] to Cargo.toml. #94

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Conversation

mutexlox-signal
Copy link
Contributor

This works around rust-lang/cargo#6745 and allows cubeb-pulse-rs to appear as a subdirectory of a workspace member in another project (for instance, cubeb-rs).

This works around rust-lang/cargo#6745 and
allows cubeb-pulse-rs to appear as a subdirectory of a workspace
member in another project (for instance, cubeb-rs).
@mutexlox-signal
Copy link
Contributor Author

cc @padenot - any chance of taking a look at this? thanks!

@mutexlox-signal
Copy link
Contributor Author

cc @kinetiknz on this one as well

@mutexlox-signal
Copy link
Contributor Author

Looks like this may have cause clippy to start running on things it wasn't running on before(?)

@kinetiknz
Copy link
Contributor

Yeah, clippy is now including pulse-rs and pulse-ffi. Quick fix is to exclude those crates from the workspace (which would be equivalent to the behaviour before [workspace] was added), but it'd be better to fix the clippy errors. Similar issue showing up in mozilla/cubeb-coreaudio-rs#236 with coreaudio-sys-utils.

@mutexlox-signal
Copy link
Contributor Author

I think there are far too many errors for me to fix them in this PR, in particular as a number of them are due to missing unsafe tags, which may require invasive changes to address. For now, I will exclude these directories from the clippy check in question, and I have filed #95 to be addressed as it fits in.

@mutexlox-signal
Copy link
Contributor Author

On second thought, I think the approach I took with that last commit is not quite right; it might also break anyone running cargo clippy manually or on projects that depend on this crate. Perhaps instead we should fix the 'easy' findings and silence the more involved ones.

@mutexlox-signal
Copy link
Contributor Author

@kinetiknz this is ready for a re-review now :)

( @padenot - if you could please trigger a presubmit run so I can fix any lingering errors I missed locally, I'd appreciate it)

@mutexlox-signal
Copy link
Contributor Author

One of the nightly errors is due to rust-lang/rust-clippy#13531. I can fix the others.

@mutexlox-signal
Copy link
Contributor Author

And this should be ready for a re-run now, too

@mutexlox-signal
Copy link
Contributor Author

reformatted

@kinetiknz
Copy link
Contributor

Thank you!

@kinetiknz kinetiknz merged commit f951e72 into mozilla:dev Oct 10, 2024
2 checks passed
mutexlox-signal added a commit to mutexlox-signal/cubeb that referenced this pull request Oct 11, 2024
@mutexlox-signal
Copy link
Contributor Author

Thanks!

padenot pushed a commit to mozilla/cubeb that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants