Generate flexible array members the c99 way instead of the GNU way #994
Conversation
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
2f376eb to
05cde18
Compare
tests/rust/struct.rs
Outdated
| #[repr(C)] | ||
| struct WithFlexibleArrayMember { | ||
| x: i32, | ||
| y: [i8; 0], |
There was a problem hiding this comment.
Can you test with some other field afterwards too? Not sure what the behavior there should be, maybe it's fine.
There was a problem hiding this comment.
I had to rework the whole approach. I've added a specific type to represent flexible array members, and that makes everything much more consistent.
I'm unsure about the idiomaticity of my rust code, don't hesitate to bash me :-)
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
05cde18 to
2b2e64b
Compare
|
@emilio even if that change is correct from a compiler point of view, it would actually break mozilla code if gnu behavior is of by default because the firefox codebase is making an optimistic use of flexible array members. I guess it's still good to merge this, but with gnu behavior on by default. What do you think? |
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
2b2e64b to
4697c73
Compare
There a re three ways to express flexible array members: 1. char fam[0]; 2. char fam[1]; 3. char fam[]; 3. is the only standard way (in c99, but supported in c++ as an extension), the other two are GNU syntax (still supported in clang though). To avoid regression, let's generate the GNU syntax by default, while leaving it possible to use 3. through struct.c99_flexible_array_members Cython only supports the 1. mode.
serge-sans-paille
force-pushed
the
feature/flexible-array-members
branch
from
4697c73 to
ff2e4ef
Compare
| write!(out, "[{}]", constant); | ||
|
|
||
| last_was_pointer = false; | ||
| } | ||
| CDeclarator::FlexibleArray() => { |
There was a problem hiding this comment.
There's no need for (), just remove it from the enum declaration.
Can you elaborate? Do you have an example? |
There a re three ways to express flexible array members:
char fam[0];
char fam[1];
char fam[];
is the only standard way (in c99, but supported in c++ as an extension), the other two are GNU syntax (still supported in clang though).
Let's generate the standard syntax by default, while leaving it possible to use 1. through struct.gnu_flexible_array_members
Cython only supports the 1. mode.