Skip to content

Omit or display more detailed warning message while trying to generate declaration from Rust functions #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Omit or display more detailed warning message while trying to generate declaration from Rust functions #477

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f798917
parser: extract condition for abstractions
TheKK Feb 19, 2020
6085a0c
parser: use match statement to replace nested if-else statement
TheKK Feb 19, 2020
754216c
parser: don't warn when function is not extern c and not no_mangle
TheKK Feb 19, 2020
cdcb52f
parser: warn when function is partial exported
TheKK Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/bindgen/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,11 @@ impl Parse {
};

if let syn::Visibility::Public(_) = vis {
if sig.abi.is_omitted() || sig.abi.is_c() {
if let Some(exported_name) = named_symbol.exported_name() {
let is_extern_c = sig.abi.is_omitted() || sig.abi.is_c();
let exported_name = named_symbol.exported_name();

match (is_extern_c, exported_name) {
(true, Some(exported_name)) => {
let path = Path::new(exported_name);
match Function::load(path, self_type, &sig, false, &attrs, mod_cfg) {
Ok(func) => {
Expand All @@ -649,14 +652,17 @@ impl Parse {
error!("Cannot use fn {} ({}).", loggable_item_name(), msg);
}
}
} else {
}
(true, None) => {
warn!(
"Skipping {} - (not `no_mangle`, and has no `export_name` attribute)",
loggable_item_name()
);
}
} else {
warn!("Skipping {} - (not `extern \"C\"`", loggable_item_name());
(false, Some(_exported_name)) => {
Copy link
Collaborator

@emilio emilio Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just use (_) or (..), fwiw. But this works for me as well

Copy link
Contributor Author

@TheKK TheKK Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it to _ next time :)

warn!("Skipping {} - (not `extern \"C\"`", loggable_item_name());
}
(false, None) => {}
}
} else {
warn!("Skipping {} - (not `pub`)", loggable_item_name());
Expand Down