Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stories for header and footer components #5525

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Jan 22, 2025

Laura and Wolasi asked for these. (I also moved the header and footer components into the components/ folder, since they're... You know, components.

@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Jan 22, 2025
@Vinnl Vinnl requested review from codemist and flozia January 22, 2025 10:52
@Vinnl Vinnl self-assigned this Jan 22, 2025
@@ -55,7 +55,7 @@ export const StorybookEmailRenderer = (props: Props) => {
padding: 20px;
display: flex;
flex-direction: column;
align-items: center;
align-items: stretch;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emails apparently only looked wide because the content made the container grow, but with just the footer/header, they were very cramped 😅

@@ -89,7 +89,7 @@ export const StorybookEmailRenderer = (props: Props) => {
`
: renderResult.html,
}}
className={props.emulateDarkMode ? "dark-mode-enforced" : ""}
className={`body ${props.emulateDarkMode ? "dark-mode-enforced" : ""}`}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't end up needing this class. Could remove it too, I guess 🤷

Copy link

@Vinnl Vinnl merged commit 8d6ca90 into main Jan 23, 2025
16 checks passed
@Vinnl Vinnl deleted the email-component-stories branch January 23, 2025 14:08
Copy link

Cleanup completed - database 'blurts-server-pr-5525' destroyed, cloud run service 'blurts-server-pr-5525' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants