Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pre-redesign settings page #5520

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Deprecate pre-redesign settings page #5520

merged 7 commits into from
Jan 23, 2025

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented Jan 20, 2025

References:

Jira: MNTOR-3828

Description

Removes the pre-redesign settings page including:

  • feature flag SettingsPageRedesign
  • old settings page view
  • deprecated components
  • deprecated styling
  • duplicate unit tests

How to test

  1. The feature flag SettingsPageRedesign should not be listed anymore
  2. Visiting the settings page /user/settings should not result in any visible issues
    1. Edit your info: /settings/edit-info
    2. Set notifications: /settings/notifications
    3. Manage account: /settings/manage-account

Checklist

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • All acceptance criteria are met.
  • Jira ticket has been updated with suggestions for QA when this PR is deployed to stage.

@flozia flozia requested a review from codemist January 20, 2025 13:17
@flozia flozia self-assigned this Jan 20, 2025
@flozia flozia requested a review from rhelmer January 20, 2025 13:21
Copy link

@flozia flozia merged commit 2213d78 into main Jan 23, 2025
16 checks passed
@flozia flozia deleted the mntor-3828 branch January 23, 2025 10:57
Copy link

Cleanup completed - database 'blurts-server-pr-5520' destroyed, cloud run service 'blurts-server-pr-5520' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants