Use optional chaining to avoid undefined monthly_monitor_report #5511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3848
Description
Use optional chaining to avoid
monthly_monitor_report
being undefined.I believe that the problem here is that
monthly_monitor_report
can benull
in the database if the monthly report has not run successfully for this account. I also believe we started getting more of these reports because the cron job that sends this email broke temporarily (it's now fixed), but there's still a possibility for this to happen for e.g. new users.I did not add a unit test, but I did change the typescript types to reflect that this may be undefined.
How to test
The easiest way to to test locally is to ensure that
monthly_monitor_report
isnull
in thesubscribers
table.Checklist (Definition of Done)