Add modal dialog to Storybook #5496
Conversation
|
Preview URL 🚀 : https://blurts-server-pr-5496-mgjlpikfea-uk.a.run.app |
| <> | ||
| <p> | ||
| This is modal content; note that it's not possible to | ||
| interact with the content behind the modal overlay. Here's | ||
| a button to close the modal: | ||
| </p> | ||
| <Button variant="primary" onPress={() => modalState.close()}> | ||
| Close modal | ||
| </Button> | ||
| </> | ||
| )} | ||
| </ModalOverlay> | ||
| )} | ||
| </> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Just curious why we have a modal without dialog variant here, I don't think we're using this in the app?
There was a problem hiding this comment.
We're not, but I wanted to make sure people understood what you get if you use just the modal overlay, to clarify what the dialog is and what the modal is.
There was a problem hiding this comment.
Gotcha. Could we add a comment somewhere that this isn't being used in the app, since it is a UI library we wouldn't want to give off the assumption that it's an intentional FE component.
There was a problem hiding this comment.
That's a good callout, I added 7a94a77 which calls it out right in the story, what do you think?
I'll see if I get another E2E failure, they seem to be flaky today - I wouldn't expect this PR to affect the appsAndSerices button 😅
|
There seems to be an e2e test failure with the |
|
Cleanup completed - database 'blurts-server-pr-5496' destroyed, cloud run service 'blurts-server-pr-5496' destroyed |
For Wolasi's question - and to hopefully clarify the distinction between the different APIs (modal vs dialog), and why they're separate in the first place (popovers can also be modal, although usually without the grey overlay).