Make lack of plaintext emails explicit #5485
Conversation
SubPlat apparently sends plaintext emails: https://storage.googleapis.com/mozilla-storybooks-fxa/commits/d06a74b249ebfe979642fdc94f4086a3ed031312/fxa-auth-server/index.html?path=/story/subplat-emails-layout--layout-with-was-deleted We currently don't, although technically, we easily could: we'd just have to add a `text` property to the options object passed to `gTransporter.sendMail`. Since there's currently discussion about whether to send them ourselves, I figured I'd at least adopt SubPlat's style for Storybook, to make it top-of-mind that we could send them, and to make it apparent where we're not and, in case we do start sending them, to make it ease to compare and see where we include information in the HTML email that we don't in the plaintext version.
Vinnl
force-pushed
the
plaintext-email-note
branch
from
1c5ca0a to
2951213
Compare
|
Preview URL 🚀 : https://blurts-server-pr-5485-mgjlpikfea-uk.a.run.app |
| </section> | ||
| <section className="plaintext"> | ||
| <div className="badge">Plaintext</div> | ||
| <pre>{props.plainTextVersion ?? "Not set"}</pre> |
There was a problem hiding this comment.
Since we are not using plain text versions right now it does not matter too much, but should we already set this up so that the rendered HTML would show?
| <pre>{props.plainTextVersion ?? "Not set"}</pre> | |
| {props.plainTextVersion ? ( | |
| <div | |
| dangerouslySetInnerHTML={{ | |
| __html: props.plainTextVersion, | |
| }} | |
| className={props.emulateDarkMode ? "dark-mode-enforced" : ""} | |
| /> | |
| ) : ( | |
| "Not set" | |
| )} |
There was a problem hiding this comment.
@flozia I'm not sure I follow - the plain text version is an alternative to the HTML version, i.e. there shouldn't be HTML in there?
There was a problem hiding this comment.
@Vinnl In that case I misunderstood. I thought the idea was that it is (semi) plain text: When looking at the FXA email story there are still links in there — how would those be handled? In the specific example there is a “Learn more” link.
There was a problem hiding this comment.
Ha actually, I think that's a mistake on their side? Generally, it'll be up to the mail client to make spelled-out URLs clickable, or to the user to copy-paste it.
|
Cleanup completed - database 'blurts-server-pr-5485' destroyed, cloud run service 'blurts-server-pr-5485' destroyed |
SubPlat apparently sends plaintext emails:
https://storage.googleapis.com/mozilla-storybooks-fxa/commits/d06a74b249ebfe979642fdc94f4086a3ed031312/fxa-auth-server/index.html?path=/story/subplat-emails-layout--layout-with-was-deleted
We currently don't, although technically, we easily could: we'd just have to add a
textproperty to the options object passed togTransporter.sendMail. Since there's currently discussion about whether to send them ourselves, I figured I'd at least adopt SubPlat's style for Storybook, to make it top-of-mind that we could send them, and to make it apparent where we're not and, in case we do start sending them, to make it ease to compare and see where we include information in the HTML email that we don't in the plaintext version.