Add more Cirrus error logging info #5483
Conversation
|
Preview URL 🚀 : https://blurts-server-pr-5483-mgjlpikfea-uk.a.run.app |
| logger.error( | ||
| "NIMBUS_UUID_NAMESPACE environment variable is missing. Cannot generate experimentationId.", | ||
| { | ||
| accountId, |
There was a problem hiding this comment.
Let's avoid logging the accountId, any problem here is unlikely to be related to the user (more likely the variable we need is not set)
| @@ -47,6 +53,9 @@ export function getExperimentationId( | |||
| ); | |||
| return "guest-no-experimentation-id-set-by-monitor-middleware"; | |||
| } | |||
| logger.info("Using experimentationId from header for guest user", { | |||
| experimentationId, | |||
There was a problem hiding this comment.
Likewise here, let's just lot that this is being set without logging the ID.
| logger.info("Sending request to Cirrus", { | ||
| serverUrl: serverUrl.toString(), | ||
| previewMode: params.previewMode, | ||
| client_id: params.experimentationId, |
There was a problem hiding this comment.
Let's not log the experimentationId, the other params are fine.
| serverUrl, | ||
| ex, | ||
| flags, | ||
| params, |
There was a problem hiding this comment.
I think in this case it's OK (since we could be sending invalid params)
src/middleware.ts
Outdated
| @@ -43,14 +43,6 @@ export function middleware(request: NextRequest) { | |||
| }, | |||
| }); | |||
|
|
|||
| if (!existingExperimentationId) { | |||
| response.cookies.set({ | |||
There was a problem hiding this comment.
I think the point of setting the cookie is for users that are not authenticated, so there's no way to keep track of which experiments or roll-outs they are enrolled in otherwise.
There was a problem hiding this comment.
My bad, I was just supposed to remove the logger line in this file. Good catch!
|
Cleanup completed - database 'blurts-server-pr-5483' destroyed, cloud run service 'blurts-server-pr-5483' destroyed |
References:
Jira: MNTOR-
Figma:
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)