MNTOR-3882 - make next/headers a dynamic import for cron job use #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5423-mgjlpikfea-uk.a.run.app |
mansaj
approved these changes
Dec 16, 2024
rhelmer
deleted the
MNTOR-3882/make-headers-dynamic-import-for-cronjob
branch
|
Cleanup completed - database 'blurts-server-pr-5423' destroyed, cloud run service 'blurts-server-pr-5423' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3882
Description
This cron job imports Next and React code for cron job use (so we can use JSX and MJML for email templates), however
next/headersdoesn't seem to import cleanly. Looking at the compiled JS code, it's not actually used, so I think the cleanest way to deal with this is to just make it a dynamic import.How to test
npm run build-cronjobs && npm run cron:monthly-activity-freeChecklist (Definition of Done)