MNTOR-2934 - enable sentry upload #5329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhelmer
added
the
effort-XS
|
Preview URL 🚀 : https://blurts-server-pr-5329-mgjlpikfea-uk.a.run.app |
mansaj
approved these changes
Nov 22, 2024
|
Cleanup completed - database 'blurts-server-pr-5329' destroyed, cloud run service 'blurts-server-pr-5329' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-2934
Description
One small piece I didn't include in the previous PR -
next.config.jsusesUPLOAD_SENTRY_SOURCEMAPSenv var to determine if source maps should be uploaded or not, separate from theSENTRY_AUTH_KEY. TheUPLOAD_SENTRY_SOURCEMAPSisn't a secret but it does need to be declared as an arg inDockerfile.How to test
I ran this locally and was able to upload to Sentry which I'll share in Slack.
Checklist (Definition of Done)