MNTOR-3494 - pass SENTRY_AUTH_TOKEN arg to docker #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5324-mgjlpikfea-uk.a.run.app |
mansaj
approved these changes
Nov 20, 2024
rhelmer
changed the title
|
Cleanup completed - database 'blurts-server-pr-5324' destroyed, cloud run service 'blurts-server-pr-5324' destroyed |
codemist
pushed a commit
that referenced
this pull request
Nov 21, 2024
codemist
added a commit
that referenced
this pull request
Nov 21, 2024
* fix: fix comment vars * pass SENTRY_AUTH_TOKEN arg to docker (#5324) * integration * rebase * bad rebase fix * bad rebase fix --------- Co-authored-by: Joey Zhou <[email protected]> Co-authored-by: Robert Helmer <[email protected]>
codemist
added a commit
that referenced
this pull request
Nov 29, 2024
* fix ui * apply ui changes tto scanresultcard * apply styling to button * add removal under maintenance status * change cta label and write test * add new removal under maintenance page * test exposure card in new view data broker page * change terminology ot data broker * make new scan result component for resolution flow * ui fixes * add header * add header string * add box shadow * add estimated time of removal * add removal instructions view * ui tweaks * rremove ispremium force * remove commented out code * fix tests * add strings * revert back to info for sale * fix deprecated strings * move cta button to the bottom on mobile * fix ftl * fix string changes * ftl lint * add condition to remove navclose from fixview * add back arrow * Update locales-pending/dashboard-premium.ftl Co-authored-by: Francesco Lodolo <[email protected]> * chore: rename * feat: add db func for return scan results with data broker join * feat: maintenance filter * Update src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/fix/data-broker-profiles/removal-under-maintenance/page.tsx * Update src/db/tables/onerep_scans.ts * Update src/db/tables/onerep_scans.ts * fix: lint * MNTOR-3815 - Data broker manual removal integration (#5326) * fix: fix comment vars * pass SENTRY_AUTH_TOKEN arg to docker (#5324) * integration * rebase * bad rebase fix * bad rebase fix --------- Co-authored-by: Joey Zhou <[email protected]> Co-authored-by: Robert Helmer <[email protected]> * premium exposure card by default * port over databrokerremovalcard into main component and add confetti * add loader to secondary button * remove unused files * add loading animation * fix e2e tests * roll back string change * fix pbroken test * remove typescript linter * fix completion order * add mmanual resolution praise * dadd dashboard description for fixed state * add unit tests * fix * add toast error * add string * fixes * use trycatch * show loader in white on hover * remove exposureicon style * Add fetch delay and update state handling (#5341) * feat: Add util function for fetching with a delay * chore: Remove useEffect and update state handling for firstScanResultNotResolved --------- Co-authored-by: Francesco Lodolo <[email protected]> Co-authored-by: Joey Zhou <[email protected]> Co-authored-by: Robert Helmer <[email protected]> Co-authored-by: Florian Zia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3494
Description
I think the reason that the Sentry auth token variable is part of the environment the script prints when it starts but not present when the docker build takes place is because this argument isn't being explicitly passed via the Dockerfile.
How to test
I'm not sure we can test this until we merge to
main, unless we temporarily change the set of jobs that run on PRs.Checklist (Definition of Done)