use structured logging for email utils #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
1 similar comment
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
Instead of replacing the logger module by the `console.*` variants, and then mocking those variants and inspecting their calls, we can just directly look at the calls to the mocked module.
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
|
Preview URL 🚀 : https://blurts-server-pr-5230-mgjlpikfea-uk.a.run.app |
|
Cleanup completed - database 'blurts-server-pr-5230' destroyed, cloud run service 'blurts-server-pr-5230' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3713
Description
Use the Winston logging library from the email utils so we get structured logging in GCP. Right now log messages are split across several lines which makes it difficult to locate and link to problems.
How to test
Our logging library automatically falls back to console logging in local environments, so the output can be inspected that way. We'll want to check on stage that the output looks acceptable.
Checklist (Definition of Done)