Use identical GA eventCategory values for scan results CTAs.

mozilla · Nov 15, 2019 · 30becb0 · 30becb0
1 parent 4125c35
commit 30becb0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/views/partials/sign-up-banners/scan-results-sign-up.hbs b/views/partials/sign-up-banners/scan-results-sign-up.hbs
@@ -5,8 +5,8 @@
             <h2 class="sign-up-headline">{{ getString "sign-up-headline-1" }}</h2>
             {{> feature-list}}
           </div>
-          <div class="flx flx-col sign-up-cta" data-analytics-id="sign-up-banner">
-            <button class="open-oauth btn-white btn-transparent btn-big"  {{> analytics/fxa id="fx-monitor-alert-me-btn" }} data-event-category="Alert me about new breaches">
+          <div class="flx flx-col sign-up-cta">
+            <button class="open-oauth btn-white btn-transparent btn-big"  {{> analytics/fxa id="fx-monitor-alert-me-btn-banner" }} data-event-category="Alert me about new breaches - Banner">
               {{ getString "alert-about-new-breaches" }}
             </button>
             {{> sign-up-banners/browser-not-required }}

diff --git a/views/scan.hbs b/views/scan.hbs
@@ -14,10 +14,8 @@
         {{/getScanResultsHeadline}}
       {{else}}
         <h2 class="headline scan-results-headline">{{{ fluentNestedBold "scan-results-known-breaches" breachCount=foundBreaches.length }}}</h2>
-
-        <!--temp marketing "Alert me about new breaches" link-->
-        {{#if newScanPage}}
-          <button class="open-oauth blue-link temp-marketing-alert-me-link" {{> analytics/fxa id="fx-monitor-alert-me-blue-link" }} data-event-category="Alert me about new breaches - Blue link">
+        {{#if newScanPage}} <!-- New trial UI for testing call to actions -->
+          <button class="open-oauth blue-link temp-marketing-alert-me-link" {{> analytics/fxa id="fx-monitor-alert-me-blue-link" }} data-event-category="Alert me about new breaches">
             {{ getString "alert-about-new-breaches" }}
           </button>
         {{else}}
@@ -43,11 +41,15 @@
   </div>
 </main>
 <section>
-  {{#if newScanPage}}
-  <!--temp marketing Sign Up callout-->
+  {{#if newScanPage}} <!-- New trial UI for testing call to actions -->
     <div class="row txt-cntr jst-cntr flx-col temp-marketing-callout">
       <h2 class="temp-marketing-hl mw-400">{{ getString "sign-up-headline-1" }}</h2>
-      <button class="open-oauth temp-marketing-btn-blue" {{> analytics/fxa id="fx-monitor-alert-me-blue-btn" }} data-event-category="Alert me about new breaches - Blue button">{{ getString "alert-about-new-breaches" }}</button>
+        <!--  
+          the `data-event-category` attribute for this button is "Alert me about new breaches - Banner" 
+          to match the "Alert me.." button on the other version of the scan results page and to make comparisons 
+          between this button and the "Alert me.." button on the other version of the scan results page easier
+        -->
+      <button class="open-oauth temp-marketing-btn-blue" {{> analytics/fxa id="fx-monitor-alert-me-blue-btn" }} data-event-category="Alert me about new breaches - Banner">{{ getString "alert-about-new-breaches" }}</button>
       {{> sign-up-banners/browser-not-required }}
     </div>
   {{else}}