-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily change BigQueryTablePartitionExistenceSensor
s to run in reschedule mode (bug 1932180)
#6542
Merged
sean-rose
merged 2 commits into
main
from
reschedule-BigQueryTablePartitionExistenceSensor
Nov 20, 2024
Merged
Temporarily change BigQueryTablePartitionExistenceSensor
s to run in reschedule mode (bug 1932180)
#6542
sean-rose
merged 2 commits into
main
from
reschedule-BigQueryTablePartitionExistenceSensor
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reschedule mode. There's a bug in those sensors when they run in deferrable mode where the secondary queries they run to detect partitions fail, which is being fixed in apache/airflow#44225.
sean-rose
commented
Nov 20, 2024
{% if table_partition_sensor_task.poke_interval != None -%} | ||
poke_interval={{ table_partition_sensor_task.poke_interval | format_timedelta | format_repr }}, | ||
{% else -%} | ||
poke_interval=datetime.timedelta(minutes=5), | ||
poke_interval=datetime.timedelta(minutes=15), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I increased the default poke interval because starting up a Kubernetes pod every time the sensor runs is more resource intensive than when it was in deferrable mode (I think it takes around a minute to start each pod).
scholtzan
approved these changes
Nov 20, 2024
Integration report for "Fix
|
sean-rose
deleted the
reschedule-BigQueryTablePartitionExistenceSensor
branch
November 20, 2024 21:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug in
BigQueryTablePartitionExistenceSensor
when it runs in deferrable mode which is causing the secondary queries it runs to detect partitions to fail (e.g. bug 1932180).This is being fixed in apache/airflow#44225, and this PR should ultimately be reverted once that bugfix is merged, included in an
apache-airflow-providers-google
release, and we upgrade telemetry-airflow to that release.Related Tickets & Documents
bqetl_google_search_console
failed for exec_date 2024-11-18BigQueryAsyncHook.create_job_for_partition_get
apache/airflow#44225Reviewer, please follow this checklist
┆Issue is synchronized with this Jira Task