Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WNP 137 #16125

Merged
merged 6 commits into from
Mar 28, 2025
Merged

WNP 137 #16125

merged 6 commits into from
Mar 28, 2025

Conversation

alexgibson
Copy link
Member

One-line summary

Replaces #16103

Significant changes and points to review

New UITour capability: https://firefox-source-docs.mozilla.org/browser/components/uitour/docs/UITour-lib.html#Mozilla.UITour.openPreferences

  • should be able to open directly at "Browser Layout" section

This is developed with the expectation of Firefox 137 being the browser it's viewed in. Let me know if we want to be a little more defensive in case it's viewed outside of that browser.

Issue / Bugzilla link

#16086
#16109

Testing

Video loads on click only
Check window.dataLayer for video play and pause events

Vertical tabs
http://localhost:8000/en-US/firefox/137.0/whatsnew/
http://localhost:8000/en-CA/firefox/137.0/whatsnew/
http://localhost:8000/en-GB/firefox/137.0/whatsnew/
http://localhost:8000/fr/firefox/137.0/whatsnew/
http://localhost:8000/de/firefox/137.0/whatsnew/

default: http://localhost:8000/es/firefox/137.0/whatsnew/

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (0f51540) to head (cfeb047).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16125      +/-   ##
==========================================
+ Coverage   79.52%   79.56%   +0.04%     
==========================================
  Files         160      160              
  Lines        8438     8440       +2     
==========================================
+ Hits         6710     6715       +5     
+ Misses       1728     1725       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexgibson
Copy link
Member Author

This PR has been previously reviewed in #16103, bar a couple of tiny changes. Merging this rather than starting another round of review.

@alexgibson alexgibson merged commit c83deba into main Mar 28, 2025
6 checks passed
@alexgibson alexgibson deleted the wnp-137 branch March 28, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants