Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent product name for 'Firefox Translations' in Fluent (Fixes #15442) #15459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ayushsunny
Copy link
Contributor

One-line summary

Treat "Firefox Translations" as a single product name in Fluent strings.

Significant changes and points to review

  • Updated instances of { -brand-name-firefox } Translations to { -brand-name-firefox-translations } in relevant files.
  • Ensured consistency by using the pre-defined { -brand-name-firefox-translations } entry from brands.ftl across all strings.
  • Verified that the changes align with the Fluent localization standards for product naming.

Issue / Bugzilla link

Resolves Issue #15442

Testing

  • Manually checked that each modified string renders "Firefox Translations" as a single entity in the UI.
  • Confirmed the updated strings in different localization scenarios to ensure they display correctly.

@Ayushsunny
Copy link
Contributor Author

Hiii @peiying2 , could you please review this PR? It addresses the issue you raised. Thank you!

features-translate-the-languages-below-are-what = The languages below are currently supported by the { -brand-name-firefox } Translations feature:
features-translate-the-languages-below-are-what = The languages below are currently supported by the { -brand-name-firefox-translations } feature:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this can't be changed without versioning the string — obsoleting the old, adding it as a fallback (thus changing the IDs in the actual template, too) — to make sure it updates in Pontoon properly, see: https://bedrock.readthedocs.io/en/latest/l10n.html#ftl-string-ids (and also the following § Obsolete strings and § Fallback chapters on that page…)

@peiying2 should confirm whether that's the case, but it usually is:/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Firefox Translations" should be coded together as a product name in Fluent
3 participants