Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of etags and lastmod data from sitemaps #15225

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

pmac
Copy link
Member

@pmac pmac commented Sep 27, 2024

These commits will need to be deployed one at a time. The 2nd one contains the migration to remove the data from the DB, while the first removes the use of the lastmod field.

@pmac pmac changed the title remove lastmod sitemap 15224 Remove use of etags and lastmod data from sitemaps Sep 27, 2024
@pmac pmac marked this pull request as draft September 27, 2024 17:56
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.90%. Comparing base (0921c92) to head (4f4cf3e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bedrock/sitemaps/models.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15225      +/-   ##
==========================================
+ Coverage   78.82%   78.90%   +0.08%     
==========================================
  Files         158      158              
  Lines        8284     8274      -10     
==========================================
- Hits         6530     6529       -1     
+ Misses       1754     1745       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Do you plan to split into separate branches to deploy part 1 and part 2?

@pmac
Copy link
Member Author

pmac commented Oct 8, 2024

My plan was just to land this, and then push the first commit to prod, and then the 2nd.

@pmac pmac marked this pull request as ready for review October 8, 2024 20:17
@pmac pmac force-pushed the remove-lastmod-sitemap-15224 branch from 1575c72 to 4f4cf3e Compare November 21, 2024 20:52
@pmac pmac requested a review from a team as a code owner November 21, 2024 20:52
@pmac pmac merged commit 11024c6 into mozilla:main Nov 21, 2024
6 checks passed
@pmac pmac deleted the remove-lastmod-sitemap-15224 branch November 21, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants