Report time of applying experiments as a single sample to Glean #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6364 +/- ##
==========================================
+ Coverage 47.71% 52.72% +5.00%
==========================================
Files 162 125 -37
Lines 14164 12820 -1344
==========================================
Hits 6759 6759
+ Misses 7405 6061 -1344 ☔ View full report in Codecov by Sentry. |
This happens early during startup and Glean will now delay executing the actual recording until after libxul is loaded externally. This avoids forcing that load of Glean/libxul too early.
badboy
force-pushed
the
delay-glean-loading-by-explicit-time-measuring
branch
from
55ad24a
to
61e881b
Compare
|
The Glean changes landed and this would potentially address bug 1892234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works as is, but is only really useful once mozilla/glean#2942 lands