Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1898394 - Use gecko-dev repo for Fenix and Focus Android manifests #6347

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

brennie
Copy link
Member

@brennie brennie commented Aug 19, 2024

Firefox 125 was the last version to use the
@mozilla-mobile/firefox-android repo. Now it is in mozilla-central, so we can use the @mozilla/gecko-dev mirror. Unfortunately, gecko-dev does not have tagged releases, so we cannot look up manifests by their version and have to use --ref instead.

Additionally, we were looking for Fenix manifests in the @mozilla-mobile/fenix repo for version < 110. However, v110 was released from the fenix repo and v111 was the first version to use the combnined @mozilla-mobile/firefox-android repo. This has been updated.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

Firefox 125 was the last version to use the
mozilla-mobile/firefox-android repo. Now it is in mozilla-central, so
we can use the mozilla/gecko-dev mirror. Unfortunately, gecko-dev does
not have tagged releases, so we cannot look up manifests by their
version and have to use --ref instead.

Additionally, we were looking for Fenix manifests in the
mozilla-mobile/fenix repo for version < 110. However, v110 was released
from the fenix repo and v111 was the first version to use the combnined
mozilla-mobile/firefox-android repo. This has been fixed.
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 22.66%. Comparing base (c3774b2) to head (f2a103a).

Files Patch % Lines
components/support/nimbus-cli/src/config.rs 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6347      +/-   ##
==========================================
+ Coverage   22.63%   22.66%   +0.02%     
==========================================
  Files         333      333              
  Lines       29836    29860      +24     
==========================================
+ Hits         6754     6768      +14     
- Misses      23082    23092      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@linabutler linabutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you so much for doing this, Beth!

Losing tagged releases is a little unfortunate, but I think it's OK for now—and definitely not worth trying to rig up a separate client to fetch from hg.m.o, especially since we're planning to migrate m-c to GitHub in the not-too-distant future.

components/support/nimbus-cli/src/config.rs Show resolved Hide resolved
@brennie brennie force-pushed the dev/fenix-gecko-dev branch 2 times, most recently from df56260 to f2a103a Compare August 20, 2024 18:13
@brennie brennie enabled auto-merge August 20, 2024 18:13
@brennie brennie added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 6c1d73c Aug 20, 2024
16 checks passed
@brennie brennie deleted the dev/fenix-gecko-dev branch August 20, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants