-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Rust for recorded context to handle event store queries #6322
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6322 +/- ##
==========================================
- Coverage 49.30% 42.03% -7.28%
==========================================
Files 146 184 +38
Lines 13708 16101 +2393
==========================================
+ Hits 6759 6768 +9
- Misses 6949 9333 +2384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7884da9
to
507b115
Compare
507b115
to
e000892
Compare
766b1f0
to
024e66f
Compare
components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt
Show resolved
Hide resolved
components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt
Show resolved
Hide resolved
024e66f
to
bd828c8
Compare
let targeting_helper = self.create_targeting_helper_with_context(serde_json::to_value( | ||
state.targeting_attributes.clone(), | ||
)?); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to clone, since there is a blanket impl for &T where T: Serialize
let targeting_helper = self.create_targeting_helper_with_context(serde_json::to_value( | |
state.targeting_attributes.clone(), | |
)?); | |
let targeting_helper = self.create_targeting_helper_with_context(serde_json::to_value( | |
&state.targeting_attributest, | |
)?); |
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.