Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #6254 tries to fix the issue. Turns out the rule might be reversed in swiftlint mentioned by @linabutler #6254 (comment)
realm/SwiftLint#5601 has more discussion about the issues with the lint. For the sake of our PRs, lets just disable the rule for now (as we don't know when it'll get merged and version bumped). There's a broader discussion about locking swiftlint to prevent these kind of issues here https://bugzilla.mozilla.org/show_bug.cgi?id=1900934 but that'll take a little more discussion before we do anything substantial
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.