Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci full] Trying to untangle rusqlite feature flags #5944

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mhammond
Copy link
Member

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@mhammond mhammond marked this pull request as draft November 24, 2023 22:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11b6f77) 26.97% compared to head (ff02131) 30.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5944      +/-   ##
==========================================
+ Coverage   26.97%   30.64%   +3.66%     
==========================================
  Files         377      367      -10     
  Lines       47881    42147    -5734     
==========================================
  Hits        12916    12916              
+ Misses      34965    29231    -5734     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhammond mhammond force-pushed the rusqlite-features-cleanup branch 5 times, most recently from 5f123bc to d20a2ca Compare November 25, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants