add IntervalData struct #5205
Merged
add IntervalData struct #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddai
force-pushed
the
create-intervaldata-struct
branch
from
b83d719
to
a9e3fd7
Compare
jeddai
force-pushed
the
create-intervaldata-struct
branch
from
a9e3fd7
to
e5b6d1f
Compare
travis79
reviewed
Oct 27, 2022
components/nimbus/src/lib.rs
Outdated
| buckets: VecDeque::new(), | ||
| starting_instant: Instant::now(), | ||
| }; | ||
| data.buckets.push_front(0); |
There was a problem hiding this comment.
Both the increment and rotate handle this case, I don't think you necessarily need to push an i32 into it here in the constructor.
There was a problem hiding this comment.
Since they no longer handle this is this resolved?
Codecov ReportBase: 41.06% // Head: 41.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5205 +/- ##
==========================================
+ Coverage 41.06% 41.78% +0.72%
==========================================
Files 170 172 +2
Lines 12875 13066 +191
==========================================
+ Hits 5287 5460 +173
- Misses 7588 7606 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a struct for the IntervalData required for behavioral targeting.
EXP-2874
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[ac: android-components-branch-name]and/or[fenix: fenix-branch-name]to the PR title.