Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate synced bookmark frecencies #847

Closed
linabutler opened this issue Mar 24, 2019 · 0 comments · Fixed by #1067
Closed

Recalculate synced bookmark frecencies #847

linabutler opened this issue Mar 24, 2019 · 0 comments · Fixed by #1067
Assignees
@linabutler
Milestone
2019-04-26

Comments

@linabutler
Copy link
Member

#723 added a moz_places_stale_frecencies table to hold Place IDs with stale frecencies, but doesn't recalculate them yet. It's expensive to recalculate everything using the current frecency algorithm, but there are a few things we could do:

  • Recalculate up to a fixed limit (400 on Desktop) after every sync.
  • Recalculate a fixed number when maintenance is run.
  • Periodically recalculate on a background thread that we manage in Rust.
  • Switch to @thomcc's new frecency algorithm (Use exponential decay frecency algorithm #610).
@linabutler linabutler mentioned this issue Mar 24, 2019
Merged
@jdragojevic jdragojevic added this to the 2019-04-26 milestone Mar 28, 2019
@jdragojevic jdragojevic added backlog and removed next labels Mar 29, 2019
@rfk rfk added next and removed backlog labels Apr 12, 2019
linabutler added a commit that referenced this issue Apr 23, 2019
@linabutler
Recalculate synced bookmark frecencies.
76e0359 
This commit recalculates stale frecencies for synced bookmark URLs,
chunking them to allow transactions on the main connection to interrupt
frecency calculation.

This commit also changes `score_recent_visits` to use the correct
timestamp unit: `now()` and `v.visit_date` are in milliseconds, not
microseconds as on Desktop.

Closes #847.
@linabutler linabutler mentioned this issue Apr 23, 2019
Merged
4 tasks
linabutler added a commit that referenced this issue Apr 23, 2019
@linabutler
Recalculate synced bookmark frecencies.
8f2c7b5 
This commit recalculates stale frecencies for synced bookmark URLs,
chunking them to allow transactions on the main connection to interrupt
frecency calculation.

This commit also changes `score_recent_visits` to use the correct
timestamp unit: `now()` and `v.visit_date` are in milliseconds, not
microseconds as on Desktop.

Closes #847.
linabutler added a commit that referenced this issue Apr 23, 2019
@linabutler
Recalculate synced bookmark frecencies.
8f0cb16 
This commit recalculates stale frecencies for synced bookmark URLs,
chunking them to allow transactions on the main connection to interrupt
frecency calculation.

This commit also changes `score_recent_visits` to use the correct
timestamp unit: `now()` and `v.visit_date` are in milliseconds, not
microseconds as on Desktop.

Closes #847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linabutler linabutler

Labels
None yet
Projects
None yet
Milestone
2019-04-26
Development

Successfully merging a pull request may close this issue.

Recalculate synced bookmark frecencies mozilla/application-services
3 participants
@rfk @jdragojevic @linabutler