Skip to content

Conversation

@diox
Copy link
Member

@diox diox commented Jan 9, 2026

Helps mozilla/addons#15877

Testing

See comment inside the function for an example on how to test this locally if you are interested.


return JsonResponse({
# request._start_time is set by GraphiteRequestTimingMiddleware
'elapsed_in_app': int((time.time() - request._start_time) * 1000),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unlikely to be super relevant, we already know we are losing time outside of the app, but it was available so I figured I'd include it.

@diox diox marked this pull request as ready for review January 9, 2026 09:14
@diox diox requested review from a team and eviljeff and removed request for a team January 9, 2026 09:14
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make it a DRF view, to account for anything that might be happening in the framework? (unlikely to be a factor)

@diox
Copy link
Member Author

diox commented Jan 9, 2026

Do we want to make it a DRF view, to account for anything that might be happening in the framework? (unlikely to be a factor)

My plan is to start simple first, and avoid complexity I don't need where possible. Hopefully I won't need to make a DRF view, but we'll see...

@diox diox merged commit 33427d3 into mozilla:master Jan 9, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants