Avoid raising exceptions when parsing invalid manifests #24185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that fields that should contain a dict do return one - we're calling this parsing code before the linter has run, so the manifest could be invalid. When we detect such invalid fields, raise InvalidManifest, the validation task catches that to let the linter run and provide an appropriate error message to the developer.
diox
requested review from
a team and
eviljeff
and removed request for
a team
eviljeff
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that fields that should contain a dict do return one - we're calling this parsing code before the linter has run, so the manifest could be invalid.
When we detect such invalid fields, raise
InvalidManifest, the validation task catches that to let the linter run and provide an appropriate error message to the developer.Fixes mozilla/addons#15688
Testing
developerbrowser_specific_settings(orapplications)browser_specific_settings->geckobrowser_specific_settings->gecko->data_collection_permissionsInstead of having a generic error, you should get the proper linter error about the property like
"/browser_specific_settings/gecko/data_collection_permissions" must be objectfor instance.