Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify a package name or version, this package is not published #714

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

diox
Copy link
Member

@diox diox commented Jan 8, 2025

@diox
Copy link
Member Author

diox commented Jan 8, 2025

Urgh, we have not built this project in a while, cimg/php8.2-node is now pulling Node 22, and we run into issues node-sass, which is EOL... https://sass-lang.com/blog/node-sass-is-end-of-life/

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (04dff0a) to head (0ac0e38).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files           9        9           
  Lines         556      556           
  Branches      143      143           
=======================================
  Hits          487      487           
  Misses         62       62           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diox diox requested a review from willdurand January 9, 2025 10:58
@diox
Copy link
Member Author

diox commented Jan 9, 2025

Urgh, we have built this project in a while, cimg/php8.2-node is now pulling Node 22, and we run into issues node-sass, which is EOL... https://sass-lang.com/blog/node-sass-is-end-of-life/

Added a workaround, using Node 18 in test-wptheme as well through an orb, and filed mozilla/addons#15273

@diox diox merged commit bbc3f90 into main Jan 9, 2025
3 checks passed
@diox diox deleted the no-package-name-or-version branch January 9, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants