Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Gifs are squished on Android 4.2.2 #185

Closed
secretrobotron opened this issue Jul 18, 2016 · 5 comments · Fixed by #220
Closed

Gifs are squished on Android 4.2.2 #185

secretrobotron opened this issue Jul 18, 2016 · 5 comments · Fixed by #220
Assignees

Comments

@secretrobotron
Copy link
Contributor

About 31 of our users are on Android 4.2.2, on which the tutorial images appear pretty squished:

screenshot_2016-07-18-17-41-52

@brianmwadime is this fixable, or just how 4.2.2 kinda works?

@secretrobotron
Copy link
Contributor Author

Yeah, this is definitely OK in 4.4.2 (just tested).

@brianmwadime
Copy link
Contributor

@secretrobotron confirming what the issue might be.

@secretrobotron
Copy link
Contributor Author

I did a bit of poking around yesterday. It might be some deprecated layout attribute that was used a while ago, but I couldn't find anything definitive.

@ryanwarsaw
Copy link
Contributor

It's definitely happening on versions older than 4.2.2 as well, I've managed to duplicate the issue and am in the process of issuing a fix for it.

@ryanwarsaw
Copy link
Contributor

This issue is caused by the attribute adjustViewBounds that doesn't function as expected on Android 17 or earlier in order to maintain compatibility with legacy behavior of other components.

I've determined that this can be fixed without having to do any bug fixing with one of our upstream dependencies (although I'd like to submit a PR there as well). This is currently in-progress.

ryanwarsaw added a commit that referenced this issue Oct 2, 2016
Fix legacy behavior of adjustViewBounds attribute on Android 17 and below
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants