Decouple Dockerfile into build and train #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissyx
force-pushed
the
docker-decouple
branch
18 times, most recently
from
97e340b
to
e155e43
Compare
reuben
approved these changes
Jun 15, 2020
| @@ -0,0 +1,8 @@ | |||
| DEEPSPEECH_REPO ?= https://github.com/mozilla/DeepSpeech.git | |||
There was a problem hiding this comment.
Should we move these docker related files to a "docker" subfolder instead of leaving them in the root?
There was a problem hiding this comment.
I'm not sure, is this really adding noise right now?
There was a problem hiding this comment.
It's not adding noise, just thinking that now we have a top level Makefile that only does a very specific thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.