Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return raw scores in confidence value (Fixes #3004) #3021

Merged
merged 1 commit into from
May 27, 2020
Merged

Return raw scores in confidence value (Fixes #3004) #3021

merged 1 commit into from
May 27, 2020

Conversation

reuben
Copy link
Contributor

@reuben reuben commented May 27, 2020

This should eliminate confusion where the adjusted order does not match the sorted order as well as avoid behavior discrepancies between runs with and without a scorer.

@reuben reuben changed the title Return raw scores in confidence value Return raw scores in confidence value (Fixes #3004) May 27, 2020
kdavis-mozilla
kdavis-mozilla approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reuben reuben merged commit af4bc31 into master May 27, 2020
@reuben reuben deleted the confidence-raw-scores branch May 27, 2020 16:40
@reuben reuben mentioned this pull request May 27, 2020
Closed
reuben added a commit that referenced this pull request Jul 30, 2020
@reuben
Remove unused Scorer method
6141740 
This method was made unused by #3021
after reports such as #3004
of confusion interpreting the confidence values.
@reuben reuben mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdavis-mozilla kdavis-mozilla kdavis-mozilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuben @kdavis-mozilla