Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs centered on ReadTheDocs instead of GitHub #2949

Merged
merged 4 commits into from
Apr 28, 2020
Merged

Docs centered on ReadTheDocs instead of GitHub #2949

merged 4 commits into from
Apr 28, 2020

Conversation

reuben
Copy link
Contributor

@reuben reuben commented Apr 27, 2020

No description provided.

@reuben reuben marked this pull request as ready for review April 27, 2020 18:19
@reuben
Copy link
Contributor Author

reuben commented Apr 27, 2020

This basically makes ReadTheDocs the source of truth and slims down the main README to avoid linking into GitHub where possible. We need to write usage docs for the .NET bindings, and then after that things should be mostly self contained on RTD. There's one or two links to the native client README for building from source but that should be it. Hopefully this solves #2824 by redirecting people to instructions that work reliably with the latest released model by default.

We may still want to have release branches as we go into maintenance of 1.x, but we don't have to keep changing the default branch on GitHub.

Built docs are here: https://community-tc.services.mozilla.com/api/queue/v1/task/Kh_P4l6jRZ6AP0o4skMJPA/runs/0/artifacts/public/doc-html.zip

SUPPORT.rst Outdated
@@ -4,14 +4,10 @@ Contact/Getting Help
There are several ways to contact us or to get help:


#.
`\ **FAQ** <https://github.com/mozilla/DeepSpeech/wiki#frequently-asked-questions>`_ - We have a list of common questions, and their answers, in our `FAQ <https://github.com/mozilla/DeepSpeech/wiki#frequently-asked-questions>`_. When just getting started, it's best to first check the `FAQ <https://github.com/mozilla/DeepSpeech/wiki#frequently-asked-questions>`_ to see if your question is addressed.
#. `FAQ <https://github.com/mozilla/DeepSpeech/wiki#frequently-asked-questions>`_ - We have a list of common questions, and their answers, in our `FAQ <https://github.com/mozilla/DeepSpeech/wiki#frequently-asked-questions>`_. When just getting started, it's best to first check the `FAQ <https://github.com/mozilla/DeepSpeech/wiki#frequently-asked-questions>`_ to see if your question is addressed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to keep the wiki? I feel like nobody reads it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking about that, we don't check or maintain the FAQ often enough. Should probably just tell people to search Discourse and the issue tracker.

doc/Decoder.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few little issues

@@ -65,7 +65,7 @@ If you have a capable (NVIDIA, at least 8GB of VRAM) GPU, it is highly recommend
pip3 uninstall tensorflow
Copy link
Contributor

@kdavis-mozilla kdavis-mozilla Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment on this file. Should the github reference on line 126 be re-worded as you did with the other github references?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about embedding a full listing of the flag definitions in a page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's generated from the code, why not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Installing bindings from source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

If pre-built binaries aren't available for your system, you'll need to install them from scratch. Follow these :github:`native client installation instructions <native_client/README.rst>`.
If pre-built binaries aren't available for your system, you'll need to install them from scratch. Follow the :github:`native client build and installation instructions <native_client/README.rst>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to/can we not link to GitHub here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally we move the build instructions to ReadTheDocs as well.

@@ -1,4 +1,4 @@
Full project description and documentation on GitHub: [https://github.com/mozilla/DeepSpeech](https://github.com/mozilla/DeepSpeech).
Full project description and documentation on [https://deepspeech.readthedocs.io/](https://deepspeech.readthedocs.io/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a note on this file but hasn't native_client/java/README.md been forgotten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java README is more akin to the native_client README or the dotnet README, where it's mostly about development and building rather than using of pre-built binaries. We need to write the usage instructions for them, and then add those to RTD too.

@reuben
Copy link
Contributor Author

reuben commented Apr 28, 2020

Addressed immediate comments, will work on Java and .NET stuff in follow up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants