This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Add pagination, fix misreporting # of ASGs #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milescrabill
changed the title
Member
|
I think the SDK might provide a higher level pagination facility that you could use (looking at aws/aws-sdk-go#247). |
Contributor
Author
|
re: that comment, fixed in #15 |
added 2 commits
July 5, 2015 15:03
* use-pagination: add comments using waitgroup (duh) initial version with counter for completed regions
milescrabill
changed the title
Member
There was a problem hiding this comment.
When the describe API call fails wg.Done() is never called and ch is never closed (likewise in AllInstances).
whd
added a commit
that referenced
this pull request
Jul 8, 2015
Add pagination, fix misreporting # of ASGs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.