chore: simpler ber2der + too-big-length detection #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ber2der skip building of intermediate tree of BER objects. Rather write immediately the DER bytes patching as necessary the length when it becomes known. Make code more idiomatic using append() on byte slices. If BER data use fixed length encoding, report an error when the total length of children is less than the length declared in the parent. Previously such error was ignored with the parent length fixed in the DER encoding.
|
Hello @ibukanov. You may want to check out #73 and #88 and perhaps submit this to https://github.com/smallstep/pkcs7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ber2der skip building of intermediate tree of BER objects. Rather write immediately the DER bytes patching as necessary the length when it becomes known. Make code more idiomatic using append() on byte slices.
If BER data use fixed length encoding, report an error when the total length of children is less than the length declared in the parent. Previously such error was ignored with the parent length fixed in the DER encoding.