Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use Pipfile #208

Closed
wants to merge 3 commits into from

Conversation

stephendonner
Copy link
Contributor

Passing ad-hoc here: https://qa-preprod-master.fxtest.jenkins.stage.mozaws.net/job/go-bouncer.adhoc/102/console

As-is, our Pyup.io bot support for dependencies will stop working for these tests - we'd need to address that with something like pyupio/pyup#197 (comment) (given the multi-directory nature of this repo, I haven't yet figured it out).

@davehunt @oremj @m8ttyB r?

@codecov-io
Copy link

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #208   +/-   ##
======================================
  Coverage    39.4%   39.4%           
======================================
  Files           8       8           
  Lines         604     604           
======================================
  Hits          238     238           
  Misses        341     341           
  Partials       25      25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e98cd5...4d64993. Read the comment docs.

Copy link
Contributor

@m8ttyB m8ttyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A curiosity, how does one update the .lock file with the correct hashes? Is that done automatically or should we update our docs to discuss how to do that?

@stephendonner
Copy link
Contributor Author

It's done automatically when you either blow away Pipfile.lock, or issue

pipenv lock

https://docs.pipenv.org/basics/#pipfile-lock-security-features

Copy link
Contributor

@m8ttyB m8ttyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Contributor

@davehunt davehunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned with the mass move to Pipfile. I was of the understanding that we were going to experiment with pyup's initial support for them, and now we have three open pull requests switching to them. Can we hold off for now? I don't see an immediate advantage to this, especially as we're typically using Docker to run the tests.

Copy link
Contributor

@davehunt davehunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this removes pyup.io support, I think we should hold off until we can address that.

@stephendonner
Copy link
Contributor Author

👍 - I'll hold off until we've proven the Pyup.io yaml model works.

@stephendonner
Copy link
Contributor Author

Because we want to retain @pyup-bot support for auto-dependency updating, and I haven't seen my initial approach working yet (specifically: with lockfile, and two+ sets of separate dependencies/tree levels), I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants