This repository was archived by the owner on Oct 15, 2021. It is now read-only.
Handle empty fields as undefined in the XML file.#62
Closed
Conversation
glasserc
approved these changes
Feb 15, 2017
Contributor
glasserc
left a comment
glasserc
left a comment
There was a problem hiding this comment.
I feel like I don't have context on what's going on here but this looks OK to me. Are we trying to preserve falsy items, or strip them out? I guess strip them out, but the diff in mozilla-services/kinto-dist#109 seems to suggest that we need to preserve them?
|
|
||
| for field in ['name', 'os']: | ||
| if field in item: | ||
| if field in item and item[field]: |
Contributor
There was a problem hiding this comment.
Are these dicts? Can you use get?
Contributor
Author
There was a problem hiding this comment.
Yes I guess I can. I don't know why the functional test if failling though.
Contributor
Author
|
This was fixed in the jsonschema |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs mozilla-services/kinto-dist#109