Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

#1196: Change to SystemWebView.java to suppress at least one X-Requested-With #1713

Closed
wants to merge 2 commits into from

Conversation

JordanShaak
Copy link
Contributor

From my testing this addresses the X-Requested-With in the very first request sent to a given site, though it doesn't cover additional requests as mentioned in the discussion in #1196.

Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Can you squash the two commits into a single one? :)

@@ -160,7 +163,9 @@ public void loadUrl(String url) {
// called by webview when clicking on a link, and not when opening a new page for the
// first time using loadUrl().
if (!client.shouldOverrideUrlLoading(this, url)) {
super.loadUrl(url);
Map<String, String> additionalHeaders = new HashMap<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: final

@pocmo
Copy link
Contributor

pocmo commented Nov 17, 2017

Merged cleaned up patch in #1733.

@pocmo pocmo closed this Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants