Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Add tracking protection backend #311

Closed
mcomella opened this issue Jan 11, 2018 · 2 comments
Closed

Add tracking protection backend #311

mcomella opened this issue Jan 11, 2018 · 2 comments
Assignees
@mcomella
Labels
P1 High impact and/or high frequency
Milestone
v1.1

Comments

@mcomella
Copy link
Contributor

We're blocked on the UX in #234, but we can start with the backend here.
@mcomella mcomella added the P1 High impact and/or high frequency label Jan 11, 2018
@mcomella mcomella added this to the v1.1 milestone Jan 11, 2018
@mcomella
Copy link
Contributor Author

See what Focus does and (probably) do that! A lot of the code might still exist in product for us.

@mcomella
Copy link
Contributor Author

Let's see how this affects #267 (pop ups) after this lands.

@mcomella mcomella self-assigned this Jan 12, 2018
@mcomella mcomella mentioned this issue Jan 12, 2018
Closed
mcomella added a commit to mcomella/firefox-tv that referenced this issue Jan 12, 2018
@mcomella
Closes mozilla-mobile#311: re-enable tracking protection.
618f174 
I think request.isForMainFrame() is unnecessary because of this line in
UrlMatcher.matches:

        if (pageHost != null && pageHost.equals(resourceHost)) {
            return false;
        }

Which whitelists first party requests: this is assuming the `pageHost`, which
comes from `TrackingProtectionWebViewClient.currentPageUrl`, actually
represents the current page loading (and thus the main frame).

I noted that my Android TV emulator seems to block the same numbers of trackers
as Focus.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
P1 High impact and/or high frequency
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
1 participant
@mcomella